Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Django 3 support #25

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

coloradocarlos
Copy link
Contributor

Fix for #24

@arpankotecha
Copy link

We are blocked on this as well. Anyway to get this pr merged and released?

@jacobwegner
Copy link
Contributor

@arpankotecha I'm not sure when we'll get to the next release; you can install this branch using:

pip install "django-gapc-storage @https://github.com/coloradocarlos/django-gapc-storage/archive/d0425691cd51dd5f2444cd61b540866486bcacbc.zip"

In the long term, I think this repository will likely be archived in favor of the Gcloud backend provided via django-storages.

It should be pretty straightforward to swap this library out for django-storages; pay attention to the GS_FILE_OVERWRITE setting:

  • In django-gapc-storage, by default, if a file with the same name exists, we mirror Django's default file backend, which does not overwrite.
  • django-storages has GS_FILE_OVERWRITE = True by default, which does overwrite; setting GS_FILE_OVERWRITE = False would mirror the default file backend / django-gapc-storage.

@arpankotecha
Copy link

Understood. Thank you for such a quick and thoughtful response. 🙏🙏🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants